taurusxin
/
ncmdump-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

fix: only fetch when not embedded

This commit is contained in:
TaurusXin 2024-10-21 10:41:10 +08:00
parent cf39731cb4
commit 3072d7f9cf
Signed by: taurusxin
GPG Key ID: C334DCA04AC2D2CC
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ncmcrypt/ncmcrypt.go
View File

@ -161,7 +161,8 @@ func (ncm *NeteaseCloudMusic) Dump(targetDir string) (bool, error) {
// FixMetadata will fix the missing metadata for target music file, the source of the metadata comes from origin ncm file. // FixMetadata will fix the missing metadata for target music file, the source of the metadata comes from origin ncm file.
// Since NeteaseCloudMusic version 3.0, the album cover image is no longer embedded in the ncm file. If the parameter is true, it means downloading the image from the NetEase server and embedding it into the target music file (network connection required) // Since NeteaseCloudMusic version 3.0, the album cover image is no longer embedded in the ncm file. If the parameter is true, it means downloading the image from the NetEase server and embedding it into the target music file (network connection required)
func (ncm *NeteaseCloudMusic) FixMetadata(fetchAlbumImageFromRemote bool) (bool, error) { func (ncm *NeteaseCloudMusic) FixMetadata(fetchAlbumImageFromRemote bool) (bool, error) {
if fetchAlbumImageFromRemote { // only fetch album image from remote when it's not embedded in the ncm file
if len(ncm.mImageData) <= 0 && fetchAlbumImageFromRemote {
// get the album pic from url // get the album pic from url
resp, err := http.Get(ncm.mAlbumPicUrl) resp, err := http.Get(ncm.mAlbumPicUrl)
if err != nil { if err != nil {